-
-
Notifications
You must be signed in to change notification settings - Fork 35
Drop references to a "function registry" #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some food for thought comments. Otherwise looks good.
|
|
||
| Implementations MUST _accept_ each **REQUIRED** _function_ and | ||
| MUST _accept_ all _options_ defined as **REQUIRED** for those _functions_. | ||
| Implementations MUST _accept_ each REQUIRED _default function_ and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't make this change: I don't think it is necessary.
|
|
||
| _Functions_ can define _options_. | ||
| An _option_ can be **REQUIRED** or **RECOMMENDED**. | ||
| An _option_ can be REQUIRED or RECOMMENDED. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting here is intentional. Many such below. Won't repeat.
|
About the label: I was waiting to rename it based on discussion of what the name should be 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for merge per 2025-02-10 call, except for my comments
spec/functions/number.md
Outdated
| > [!NOTE] | ||
| > The option `select` does not accept the value `ordinal` because selecting | ||
| > currency values using ordinal rules makes no sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this (and line 523) doesn't work because it is a normative directive in a note. We should either override the option select in this function or we should make this IMPORTANT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed these notes, as the select option was removed from :currency and :unit functions in #991.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, needed to force-push a fix, as this and a few other problems were due to the preceding merge applying incorrect changes.
spec/functions/number.md
Outdated
| > [!NOTE] | ||
| > The option `select` does not accept the value `ordinal` because selecting | ||
| > unit values using ordinal rules makes no sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment on line 391
|
Per discussion in the 2025-02-10 teleconference, I am merging these changes. Others might be needed to meet v47 release criteria. |
As discussed previously (most recently in #974 (comment)), we should update our terminology to no longer refer to a "function registry", a term that we don't actually define.
This PR applies that change, along with some incidental cleanup. The term default function is introduced, and used where appropriate.
The GitHub label
registryshould probably also be renamed asdefault-functions.